Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: Open Responses Styling and Layout (#33717)" #35474

Merged
merged 4 commits into from
Oct 21, 2024
Merged

Revert "fix: Open Responses Styling and Layout (#33717)" #35474

merged 4 commits into from
Oct 21, 2024

Conversation

tecoholic
Copy link
Contributor

Description

This reverts commit 1dab744 introduced in #33717, which added ORA specific styles into the Platform's SCSS.

The fix is moved to ORA in openedx/edx-ora2#2233.

Useful information to include:

  • Impacts "Instructors"/"Staff"

Before:
ora_before

After:
ora_after

Supporting information

Link to other information about the change, such as Jira issues, GitHub issues, or Discourse discussions.
Be sure to check they are publicly readable, or if not, repeat the information here.

Testing instructions

Deadline

"None"

Other information

Include anything else that will help reviewers and consumers understand the change.

  • Does this change depend on other changes elsewhere?
  • Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
  • If your database migration can't be rolled back easily.

@openedx-webhooks
Copy link

Thanks for the pull request, @tecoholic!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @openedx/wg-maintenance-edx-platform. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Sep 12, 2024
@tecoholic tecoholic mentioned this pull request Sep 12, 2024
Merged
5 tasks
@mphilbrick211 mphilbrick211 added the needs reviewer assigned PR needs to be (re-)assigned a new reviewer label Sep 17, 2024
@itsjeyd
Copy link
Contributor

itsjeyd commented Sep 20, 2024

@openedx/2u-aurora Since this has openedx/edx-ora2#2233 as a companion PR, would your team be able to review it?

CC @mphilbrick211

@itsjeyd itsjeyd added needs reviewer assigned PR needs to be (re-)assigned a new reviewer and removed needs reviewer assigned PR needs to be (re-)assigned a new reviewer labels Sep 20, 2024
pomegranited
pomegranited approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@pomegranited pomegranited left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks great @tecoholic :)

  • I tested this using the ORA in the Demo course.
  • I read through the code
  • I checked for accessibility issues N/A
  • Includes documentation N/A
  • User-facing strings are extracted for translation N/A

@pomegranited
Copy link
Contributor

@ChrisChV or @bradenmacdonald would you be willing to merge this PR during the next available merge window?

@ChrisChV
Copy link
Contributor

I'm sorry. I had to take care of something urgent, and I missed the merge window. I'll merge it first thing Monday morning.

@ChrisChV ChrisChV enabled auto-merge (squash) October 21, 2024 12:32
@ChrisChV ChrisChV merged commit 8b3befc into openedx:master Oct 21, 2024
48 checks passed
@ChrisChV ChrisChV deleted the tecoholic/improved-ora-tab-styles branch October 21, 2024 12:53
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomegranited pomegranited pomegranited approved these changes

Assignees
No one assigned
Labels
needs reviewer assigned PR needs to be (re-)assigned a new reviewer open-source-contribution PR author is not from Axim or 2U
Projects
Contributions
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tecoholic @openedx-webhooks @itsjeyd @pomegranited @ChrisChV @edx-pipeline-bot @mphilbrick211